Browse Source

move notes about config_assumptions to manual TODO

main
cinnaboot 6 months ago
parent
commit
aab20f9678
  1. 7
      docs/TODO
  2. 43
      docs/config_assumptions.md

7
docs/TODO

@ -20,7 +20,12 @@ Manual TODO file, no claude's allowed!
- the config_loader module needs to be refactored, and likely needs some - the config_loader module needs to be refactored, and likely needs some
logic moved to the bodies module (which should probably be renamed logic moved to the bodies module (which should probably be renamed
simulation) simulation)
- config file validation
- check for unrealistic orbital parameters
- update remaining configs/* to new format
- we need to keep an example with a binary system
- relative coordinates for child bodies
=== rendereing === === rendering ===
- for starters, the minimum scaling of objects should be replaced with some - for starters, the minimum scaling of objects should be replaced with some
kind of billboard system kind of billboard system

43
docs/config_assumptions.md

@ -1,43 +0,0 @@
# Configuration Issues & Known Bugs
## Active TODOs:
- ⚠ **TODO**: Update configs/solar_system.txt to new 12-field format
- ⚠ **TODO**: Update configs/example_binary_star.txt to new 12-field format
- ⚠ **TODO**: Fix Moon and Jupiter's moons positions in solar_system.txt
## Fixed Issues:
- ✅ Eccentric orbit support added
- ✅ Binary star barycenter calculation
- ✅ Refactored main.cpp into focused functions
- ✅ Initial state capture in headless mode
## Known Issues:
### Solar System Configuration Issues:
**Moon position is incorrect (configs/solar_system.txt)**
- Earth at: `(1.496e11, 0, 0)` m
- Moon at: `(1.500e11, 0, 0)` m
- Distance: ~4M km, should be ~384,400 km (~3.844e8 m)
- Should be at: `(1.496e11 + 3.844e8, 0, 0)` approximately
**Jupiter's moons positions (configs/solar_system.txt)**
- Io, Europa, Ganymede, Callisto all positioned incorrectly
- Currently use absolute coordinates, should be relative to Jupiter
- Example: Io at `(8.207e11, 0, 0)` - 422M km from Jupiter (should be ~422,000 km)
### Implementation Notes:
**Coordinate system**: All positions are absolute (heliocentric), not relative to parent
**Velocity calculation**: Uses vis-viva equation: `v = sqrt(G*M*(2/r - 1/a))`
**Orbit plane**: All orbits calculated in XY plane (Z-axis perpendicular)
## Future Improvements:
### Validation:
- Add config file validation to warn about incorrectly positioned child bodies
- Check for unrealistic orbital parameters
### Features:
- Consider relative coordinate option for child bodies
- Add 3D orbit support (currently all orbits in XY plane)
Loading…
Cancel
Save