From aab20f9678e3870fc77965a5da79f5653c7e2cd6 Mon Sep 17 00:00:00 2001 From: cinnaboot Date: Tue, 6 Jan 2026 10:00:43 -0500 Subject: [PATCH] move notes about config_assumptions to manual TODO --- docs/TODO | 33 ++++++++++++++++------------- docs/config_assumptions.md | 43 -------------------------------------- 2 files changed, 19 insertions(+), 57 deletions(-) delete mode 100644 docs/config_assumptions.md diff --git a/docs/TODO b/docs/TODO index 44bc4b2..5b76d18 100644 --- a/docs/TODO +++ b/docs/TODO @@ -3,24 +3,29 @@ Manual TODO file, no claude's allowed! === Project Documentation === - - remember to periodically check the reference docs against new changes + - remember to periodically check the reference docs against new changes === Simulation/Physics === - - remove bodies on non closed orbits after they are a certain distance from - the root body, or bary-center - - add tests for each orbit type + - remove bodies on non closed orbits after they are a certain distance from + the root body, or bary-center + - add tests for each orbit type === CTAGS === - - previously we've used the Makefile to generate tags when building, - let's think about a way we can generate them without causing a conflict - for people who don't use ctags + - previously we've used the Makefile to generate tags when building, + let's think about a way we can generate them without causing a conflict + for people who don't use ctags === Simulation Config Files === - - decide on an easier to read format, likely TOML or JSON - - the config_loader module needs to be refactored, and likely needs some - logic moved to the bodies module (which should probably be renamed - simulation) + - decide on an easier to read format, likely TOML or JSON + - the config_loader module needs to be refactored, and likely needs some + logic moved to the bodies module (which should probably be renamed + simulation) + - config file validation + - check for unrealistic orbital parameters + - update remaining configs/* to new format + - we need to keep an example with a binary system + - relative coordinates for child bodies -=== rendereing === - - for starters, the minimum scaling of objects should be replaced with some - kind of billboard system +=== rendering === + - for starters, the minimum scaling of objects should be replaced with some + kind of billboard system diff --git a/docs/config_assumptions.md b/docs/config_assumptions.md deleted file mode 100644 index b558f3e..0000000 --- a/docs/config_assumptions.md +++ /dev/null @@ -1,43 +0,0 @@ -# Configuration Issues & Known Bugs - -## Active TODOs: -- ⚠️ **TODO**: Update configs/solar_system.txt to new 12-field format -- ⚠️ **TODO**: Update configs/example_binary_star.txt to new 12-field format -- ⚠️ **TODO**: Fix Moon and Jupiter's moons positions in solar_system.txt - -## Fixed Issues: -- ✅ Eccentric orbit support added -- ✅ Binary star barycenter calculation -- ✅ Refactored main.cpp into focused functions -- ✅ Initial state capture in headless mode - -## Known Issues: - -### Solar System Configuration Issues: - -**Moon position is incorrect (configs/solar_system.txt)** -- Earth at: `(1.496e11, 0, 0)` m -- Moon at: `(1.500e11, 0, 0)` m -- Distance: ~4M km, should be ~384,400 km (~3.844e8 m) -- Should be at: `(1.496e11 + 3.844e8, 0, 0)` approximately - -**Jupiter's moons positions (configs/solar_system.txt)** -- Io, Europa, Ganymede, Callisto all positioned incorrectly -- Currently use absolute coordinates, should be relative to Jupiter -- Example: Io at `(8.207e11, 0, 0)` - 422M km from Jupiter (should be ~422,000 km) - -### Implementation Notes: - -**Coordinate system**: All positions are absolute (heliocentric), not relative to parent -**Velocity calculation**: Uses vis-viva equation: `v = sqrt(G*M*(2/r - 1/a))` -**Orbit plane**: All orbits calculated in XY plane (Z-axis perpendicular) - -## Future Improvements: - -### Validation: -- Add config file validation to warn about incorrectly positioned child bodies -- Check for unrealistic orbital parameters - -### Features: -- Consider relative coordinate option for child bodies -- Add 3D orbit support (currently all orbits in XY plane)