It was a duplicate of the true_anomaly calculation already performed
by cartesian_to_orbital_elements(). Added a note in old_tests for
future refactor suggesting the replacement usage.
- Rewrite precalc_moon_orbits.py to output orbit params as dotted keys
(orbit.semi_major_axis = ...) instead of nested tables, conforming
to TOML 1.0 spec for Python compatibility
- Add print_cpp_expected_values() helper to script output
- Add new test_moon_orbits.cpp replacing old_tests version:
* MoonData struct now carries int parent_index instead of pointer
* Eliminate opaque pointer arithmetic for parent index comparison
* Collect failures in vector during sim loops, assert once at end
(reduces assertions from 763,230 to 43 per test)
- Add test_moon_orbits.toml generated from precalc script
- Merge 5 SCENARIOs into 1 with shared fixture
- Reorganize 23 SECTIONs by test type (geometry → vis-viva → period → timestep → long-term)
- Add 2 missing timestep tests (apogee radius, velocity comparison)
- Replace all qualitative checks (a > b) with WithinAbs against precalculated values
- Use named tolerance constants everywhere — zero hardcoded numbers in WithinAbs
- Add VEL_CHANGE_SMALL_DT fixture constant
- Refactor precalc script to load from TOML via Simulator class
- Output matches new test ordering
Consolidate 9 TEST_CASEs into 5 SCENARIOs with 22 SECTIONs:
- Load orbital parameters from TOML config instead of hardcoded constants
- Use precomputed expected values via precalc_analytical_propagation.py
- Apply tight tolerance constants (REL_TOL, ANG_TOL, R_TOL, V_TOL)
- Remove decorative comment blocks and redundant SCENARIO title comments
- Fix propagate_orbital_elements/orbital_elements_to_cartesian API usage
(both take parent_mass, not mu)
- Add destroy_simulation cleanup to each SCENARIO
New files: precalc_analytical_propagation.py, test_analytical_propagation.toml
Move all shared tolerance constants to src/test_utilities.h with inline
comments. Update all test files to use header constants instead of local
definitions. Add DRIFT_TOL for parabolic orbit energy checks.
Key changes:
- test_utilities.h: consolidated constants with inline descriptions,
removed per-test doc comments, added DRIFT_TOL=1e-12
- test_cartesian_to_elements_advanced.cpp: use header E_TOL, ANG_TOL,
A_TOL; local A_TOL_LARGE=2e-4 for |a|=1e11 vis-viva error cases
- test_parabolic_orbit.cpp: use V_TOL, E_TOL, REL_TOL, R_TOL, DRIFT_TOL;
add precalculated initial velocity check; remove FIXME ratio test
- test_cartesian_to_elements_basic.cpp, test_extreme_eccentricity.cpp,
test_extreme_orientation_mixed.cpp, test_extreme_timescales.cpp:
migrate remaining local constants to header
- continue.md: update tolerance reference table to match header
- scripts/precalc_parabolic_orbit.py: remove velocity sampling loop
(no longer used by C++ test)
All 624 tests pass.
- Move Tooling & Sim Engine Capabilities next to Test Refactoring Status
(status depends on the capability matrix, so they belong together)
- Merge Tooling and Sim Engine Capabilities into single section
- Remove 'Sim Engine Fix Applied' section (applied, documented in commit)
- Add SI units requirement to precalc scripts rule
- Update cross-references (Section 5 for capability matrix)
- Merge initial conditions check into single SCENARIO
- Tighten energy check to relative error (1e-10) vs KE
- Replace qualitative checks with quantitative WithinAbs assertions
- Use named tolerance constants throughout fixture
- Update precalc_parabolic_orbit.py to output SI units (m, m/s)
- Precalculate expected values with full precision from Python
- Python and C++ produce identical results in SI units
- Add semi_latus_rectum support in sim_engine.py for parabolic orbits
- Use fabs() for accumulated_rotation threshold (both directions)
- Reset body_index in reset_orbit_tracker()
- Remove unused compare_double() and compare_vec3()
- Rename min_time_days to min_time_seconds (eliminate conversion)
- Remove dead SECONDS_PER_DAY constant
- Add buffer overflow guards in dump_simulation_state()
- Use static const instead of #define for MIN_DISTANCE_CLAMP
- Refactor old_tests/test_inclined_orbits.cpp into 4 SCENARIOs
- Replace broken OrbitTracker period test with propagation-to-apogee check
- Rewrite TOML config to TOML 1.0 inline table syntax
- Add precalc script using sim_engine.py
- Fix orbit tracker: use fabs() for accumulated_rotation threshold
- New test_energy.cpp: energy conservation (10-day drift < 1e-12) and
zero-inclination prograde direction verification
- Tighten energy assertion: replaced qualitative < 5% with WithinAbs(0.0, 1e-12)
(actual drift ~2e-16 for 10-day simulation)
- Remove direction test from test_orbital_period.cpp (semantic separation)
- All 16 assertions across 3 test files passing
- Fix section numbering (was 1,2,3,5,4, now sequential)
- Remove stale dump_simulation_state NULL check TODO (already fixed)
- Retain OrbitalMetrics::angular_position 2D-only TODO for future session
- sim_engine.py: generic orbital mechanics simulator with RK4 + analytical
propagation, used to verify C++ test expected values
- test_orbital_period.py: precalculation script with safety timeout for
measuring Earth/Mars orbital periods and direction test values
- Remove SOI transition logic (buggy in both Python and C++ versions)
- Use dataclasses.replace() for immutable state updates
- Support single-line TOML inline tables via tomllib
- Fix orbit period detection: track accumulated signed rotation instead of
wrapped delta, completing on true 2π revolution (was < 0.05 rad)
- Rename quadrant_transitions → wrap_count (accurate semantics)
- Add accumulated_rotation field to OrbitTracker struct
- Consolidate create_orbit_tracker into create_orbit_tracker_with_min_time
- Extract reset_tracker_fields() helper to avoid duplication
- Use vec3_dot() for kinetic energy, vec3_magnitude() for speed calculations
- Define MIN_DISTANCE_CLAMP and SECONDS_PER_DAY as file-level constants
- Add NULL checks in dump_simulation_state for spacecraft/maneuver pointers
