- Remove TODO from simulation.cpp (interpolated burns now implemented)
- Update technical_reference.md: both trigger types now use sub-step
propagation to exact trigger time, not step boundary
- Update hohmann-rendezvous-quantization-fix.md: mark Option A as
resolved, remove outdated quantization fix suggestions
- Update propagation_refactor.md: resolve Issues 3 and 4, replace
interpolated time triggers TODO with code path unification TODO
- Remove make run target from Makefile (agents should not run graphical sim)
- Update AGENTS.md: clarify make test vs make test-build, add Simulation section
- Update technical_reference.md Build System: add tag/name/section filtering
- Add SCENARIO section docs with --section flag and fixture behavior notes
- Use ./build/orbit_test path, rename config_name to tag_name throughout
For e < 1e-10, compute argument of latitude instead of hardcoding
true_anomaly = 0.0. This preserves position consistency after circularization
burns.
- Move ascending node vector computation earlier so it's available for
the circular orbit case
- For well-defined ascending nodes (sin_i > 1e-6): compute argument of
latitude using the ascending node direction and h×n perpendicular
- For nearly-coplanar orbits (sin_i <= 1e-6): use atan2(y, x) directly
to avoid numerically unstable ascending node direction
Replace manual buffer management (malloc/free/snprintf) with a simple
stack-allocated TestOutput helper. Uses dump_simulation_state's 4-param
API with a single dump_state() method. Verification stays as individual
INFO() calls outside the loop.
Planning doc updates:
- Replace estimate table with actual measured values from DT sweep test
- Add 0.5s and 2.0s data points (69m and 228m respectively)
- Mark DT sweep tests as COMPLETED section
- Add analysis note about linear scaling with DT
New tests in test_maneuver_planning.cpp:
1. DT sweep: Hohmann transfer separation vs time step
- Runs full Hohmann transfer at DT = {0.1, 0.5, 1.0, 2.0, 5.0, 10.0}
- Verifies final separation matches expected ranges
- Confirms ecc < 0.01 for DT <= 1.0
2. DT sweep: quantization error is bounded by DT
- Tests 9 trigger offsets per DT value at DT = {1, 5, 10, 30}
- Verifies quantization error is always in [0, DT)
- Verifies execution time matches ceil-to-step-boundary
3. DT sweep: Hohmann arrival burn timing error
- Measures exact timing error at each DT
- Reports position error estimate (timing_error × velocity)
- Confirms timing error < DT
All 157 tests pass (240,742 assertions).
Previous: 154 tests, 240,445 assertions.
Mark Issues 1, 2, 5, 6 as RESOLVED. Mark Issue 3 as PARTIALLY RESOLVED.
Mark Issue 4 as UNRESOLVED (time-triggered quantization).
Update call chain diagram to show current merged structure.
Update call sites summary to show final 4 call sites (3 contexts).
Add remaining work section for interpolated time triggers and
parabolic/hyperbolic orbit support.
Consolidate execute_pending_maneuvers() into update_spacecraft_physics()
so every spacecraft goes through exactly one propagation path.
Changes:
- Remove spacecraft_handled_this_frame[256] static array
- Remove reset_spacecraft_tracking() function
- Remove execute_pending_maneuvers() function
- Check maneuver triggers before propagation in update_spacecraft_physics
- Propagate to burn time, execute burn, propagate remainder (same order
as old code)
- Remove execute_pending_maneuvers declaration from simulation.h
Benefits:
- Single propagation call per spacecraft per frame (was 2 paths)
- No static array with magic number
- Simpler call chain: no separate maneuver pass
- Enables sub-step interpolation for true-anomaly triggers
- Sets up foundation for interpolated time triggers
Adds TODO in update_spacecraft_physics about testing interpolated burns.
All 154 tests pass (240,445 assertions).
In check_maneuver_trigger() (true-anomaly branch), eliminate the
propagate_orbital_elements() look-ahead probe that was called every
frame for pending maneuvers. Replace with direct analytical computation
of dt_needed from mean anomaly delta.
Benefits:
- Eliminates ~24k redundant Kepler solves per Hohmann transfer wait
period (DT=10s, 244k s wait time)
- More precise: no discretization error from single-step propagation
- Simpler logic: removed angle_between check, wraparound detection
- Removes dead angle_between() helper function
Elliptical orbits only — added TODO for parabolic/hyperbolic support.
All 154 tests pass (240,445 assertions).
Update planning doc to reflect:
- File renames (rendezvous_hohmann -> rendezvous)
- test_maneuver_timing.cpp merged into test_maneuver_planning.cpp
- Old CW rendezvous module removed (eliminated 3 pre-existing failures)
- Current test results: 154/154 all passing
- Completed work section with full file list
- Remaining work section with optional future tasks
Rename src/rendezvous_hohmann.{h,cpp} to src/rendezvous.{h,cpp} and
tests/test_rendezvous_hohmann.{cpp,toml} to tests/test_rendezvous.{cpp,toml}.
This consolidates the rendezvous module under a simpler name since the
old CW-based rendezvous module was removed and only Hohmann transfer
functionality remains.
Update all includes, config paths, and Makefile references.
Reduce TIME_STEP from 10.0 to 0.1 and increase MAX_STEPS to 700000
to achieve sub-10m rendezvous accuracy. Update milestone dump timing
to correctly capture pre/post-burn states. Revert test config to
original values to match test expectations.
Remove src/rendezvous.h, src/rendezvous.cpp, tests/test_rendezvous.cpp,
and tests/test_rendezvous.toml. No other modules depend on these files.
Also remove RendezvousState enum, RendezvousTarget struct, and
rendezvous_target field from Spacecraft in orbital_objects.h.
For coplanar orbits (inclination < 0.01 rad), compute omega from the
eccentricity vector (longitude of periapsis) instead of forcing omega=0.
This is necessary for correct post-burn orbital element conversion,
critical for Hohmann transfer accuracy.
Update test_omega_debug to accept the new behavior: omega is computed
from the eccentricity vector direction for coplanar orbits.
Add validate_hohmann_transfer_parameters(), calculate_relative_orbit_period(),
and calculate_next_hohmann_wait_time() for robust Hohmann transfer setup.
Update required_separation() and calculate_wait_time_for_hohmann() to use
[-pi, pi] normalization instead of [0, 2pi).
- Convert typedef enum to C++ style enum
- Convert typedef struct to C++ style struct {}
- Add RendezvousState type to RendezvousTarget::state field
- Update comments to one-liners with inline descriptions
- Remove redundant struct names from comments
- Move RendezvousState and RendezvousTarget from rendezvous_types.h to orbital_objects.h
- Remove rendezvous_types.h entirely
- Simplify rendezvous.h to depend on orbital_objects.h
- Delete spacecraft.h and spacecraft.cpp (consolidated into orbital_objects.h)
- Update all include paths across codebase
- All tests pass (4 pre-existing failures unchanged)
