|
|
|
|
@ -81,6 +81,19 @@ All constants defined in `src/test_utilities.h` — use those, do not redefine l
|
|
|
|
|
- Ensure consistent tolerance usage (no hardcoded `1e-4` when `ANG_TOL_COARSE` exists). |
|
|
|
|
- Check for `compare_vec3` availability in `test_utilities` instead of 6 individual `REQUIRE_THAT` calls. |
|
|
|
|
- Run full suite again: `make test`. |
|
|
|
|
|
|
|
|
|
#### Final Systematic REQUIRE Statement Review |
|
|
|
|
After Step 3, review every `REQUIRE` in the test file: |
|
|
|
|
|
|
|
|
|
1. `grep -Rn 'REQUIRE' tests/<test_name>.cpp` |
|
|
|
|
2. Categorize each: |
|
|
|
|
- **Hardcoded tolerances** → replace with named constant |
|
|
|
|
- **Qualitative** (`a > b`, `x < 0.1`, `fabs(x) > 0`) → convert to quantitative via precalc |
|
|
|
|
- **OK as-is** → booleans, integers, strings, enums |
|
|
|
|
5. Verify precalc outputs all needed values |
|
|
|
|
6. `make test-build` → `./build/orbit_test -s '[tag]'` |
|
|
|
|
|
|
|
|
|
### Step 4: User interaction |
|
|
|
|
- **Always ask for review** before moving to the next file. |
|
|
|
|
- **Only commit when asked.** |
|
|
|
|
|
|
|
|
|
|