From b7620752142586fc4c75a43c84637c9e732c89f5 Mon Sep 17 00:00:00 2001 From: cinnaboot Date: Sat, 9 May 2026 12:00:08 -0400 Subject: [PATCH] continue.md: add section detailing final REQUIRE statement review --- continue.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/continue.md b/continue.md index 062f5e8..f3d4aa1 100644 --- a/continue.md +++ b/continue.md @@ -81,6 +81,19 @@ All constants defined in `src/test_utilities.h` — use those, do not redefine l - Ensure consistent tolerance usage (no hardcoded `1e-4` when `ANG_TOL_COARSE` exists). - Check for `compare_vec3` availability in `test_utilities` instead of 6 individual `REQUIRE_THAT` calls. - Run full suite again: `make test`. + +#### Final Systematic REQUIRE Statement Review +After Step 3, review every `REQUIRE` in the test file: + +1. `grep -Rn 'REQUIRE' tests/.cpp` +2. Categorize each: + - **Hardcoded tolerances** → replace with named constant + - **Qualitative** (`a > b`, `x < 0.1`, `fabs(x) > 0`) → convert to quantitative via precalc + - **OK as-is** → booleans, integers, strings, enums +5. Verify precalc outputs all needed values +6. `make test-build` → `./build/orbit_test -s '[tag]'` + +### Step 4: User interaction - **Always ask for review** before moving to the next file. - **Only commit when asked.**