move result parsing to new function

video_metadata/views/tmdb.py

@@ -73,23 +73,6 @@ class view_result(object):
         self.poster_path = 'no_image.png'
         self.tmdb_link = ''
 
-    # NOTE: result is parsed JSON object from tmdb API
-    def copy_result(self, result, query_type):
-        self.id = result['id']
-        self.title = result['original_title']
-        self.release_date = result['release_date']
-        self.overview = result['overview']
-        self.genre_ids = result['genre_ids']
-        self.original_language = result['original_language']
-        self.poster_path = result['poster_path']
-
-        if query_type == query_type.MOVIE:
-            self.tmdb_link = TMDB_MOVIE_LINK_URL + str(result['id'])
-        elif query_type == query_type.TV_SHOW:
-            self.tmdb_link = TMDB_TV_LINK_URL + str(result['id'])
-
-        return self
-
 
 ####################
 # flask routes
@@ -126,8 +109,7 @@ def query_movie():
             #   see) https://developers.themoviedb.org/3/search/search-movies
             if 'results' in response.parsed_response:
                 for result in response.parsed_response['results']:
-                    copy = view_result()
-                    view_results.append(copy.copy_result(result, query.query_type))
+                    view_results.append(parseTMDBResult(result, query.query_type))
 
                 storeTMDBQueryResults(query, view_results)
 
@@ -267,6 +249,25 @@ def makeTMDBQuery(query_obj, response_obj):
 
     return True
 
+# NOTE: @param result is parsed JSON object from tmdb API
+def parseTMDBResult(result, query_type):
+    parsed = view_result()
+
+    parsed.id = result['id']
+    parsed.title = result['original_title']
+    parsed.release_date = result['release_date']
+    parsed.overview = result['overview']
+    parsed.genre_ids = result['genre_ids']
+    parsed.original_language = result['original_language']
+    parsed.poster_path = result['poster_path']
+
+    if query_type == query_type.MOVIE:
+        parsed.tmdb_link = TMDB_MOVIE_LINK_URL + str(result['id'])
+    elif query_type == query_type.TV_SHOW:
+        parsed.tmdb_link = TMDB_TV_LINK_URL + str(result['id'])
+
+    return parsed
+
 def storeTMDBQueryResults(query_obj, result_list):
     conn = db.get_db()
     cur = conn.cursor()