From ff65d5751131eeb2b41d857adc36237f866fb97b Mon Sep 17 00:00:00 2001 From: cinnaboot Date: Thu, 27 Dec 2018 14:14:02 -0500 Subject: [PATCH] remove an easy TODO in render_group (add rgFree() before return) --- src/render_group.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/render_group.cpp b/src/render_group.cpp index 13fda09..b7e48cd 100644 --- a/src/render_group.cpp +++ b/src/render_group.cpp @@ -128,9 +128,10 @@ rgInitEntity(Entity* e) if (rg->render_objects[i] == nullptr) return false; - // TODO: safely free memory here when convertMeshInfo returns false - if (!convertMeshInfo(e->mesh_group.meshes[i], rg->render_objects[i], rg->use_normals)) + if (!convertMeshInfo(e->mesh_group.meshes[i], rg->render_objects[i], rg->use_normals)) { + rgFree(rg); return false; + } } return true;