Browse Source

Remove unused render_body() function and FIXME comment

main
cinnaboot 5 months ago
parent
commit
82ff7e104b
  1. 2
      docs/planning/rendering-cleanup-plan.md
  2. 1
      docs/rendering.md
  3. 1
      docs/technical_reference.md
  4. 16
      src/renderer.cpp
  5. 1
      src/renderer.h

2
docs/planning/rendering-cleanup-plan.md

@ -42,7 +42,7 @@ Remove all spacecraft texture-related code:
- Update docs/rendering.md to remove spacecraft texture references
- **PAUSE** for user review
### Step 4: Remove Unused `render_body()` Function
### Step 4: Remove Unused `render_body()` Function [COMPLETED]
- Remove `render_body()` function from renderer.cpp (lines 359-371)
- Remove function declaration from renderer.h (line 44)
- Remove FIXME comment on line 357

1
docs/rendering.md

@ -308,7 +308,6 @@ When a spacecraft is selected:
- `get_initial_camera_distance(body, sim, render_state)` - Auto-position camera based on children distance
#### Rendering
- `render_body(body, render_state)` - Draw single celestial body
- `render_maneuver_marker_screen_space(craft, maneuver, render_state)` - Draw burn indicator as 2D overlay
- `render_simulation(sim, render_state)` - Full scene rendering (3D + 2D overlays)

1
docs/technical_reference.md

@ -528,7 +528,6 @@ GUI-only application with interactive 3D visualization.
2. `render_simulation()` → for each body:
- `scale_position()` → convert to render coordinates using logarithmic scaling
- `scale_radius()` → convert to render size using exponential scaling
- `render_body()` → draw sphere with color
### SOI Transition Mechanics
- Bodies dynamically switch gravitational parents when crossing SOI boundaries

16
src/renderer.cpp

@ -328,22 +328,6 @@ float scale_radius(double radius, double scale) {
return (float)(radius * scale);
}
// FIXME: no longer used, can maybe re-use when refactoring render_simulation()
// Render a single celestial body
void render_body(CelestialBody* body, RenderState* render_state) {
Vector3 position = sim_to_render(body->global_position, render_state->distance_scale);
float radius = scale_radius(body->radius, render_state->size_scale);
Color color = {
(unsigned char)(body->color[0] * 255),
(unsigned char)(body->color[1] * 255),
(unsigned char)(body->color[2] * 255),
255
};
DrawSphereWires(position, radius, 16, 16, color);
}
void render_maneuver_marker_screen_space(Spacecraft* craft, Maneuver* maneuver, RenderState* render_state) {
if (maneuver->executed) {
return;

1
src/renderer.h

@ -36,7 +36,6 @@ void update_camera(RenderState* render_state, SimulationState* sim);
float get_initial_camera_distance(CelestialBody* body, SimulationState* sim, RenderState* render_state);
// Rendering functions
void render_body(CelestialBody* body, RenderState* render_state);
void render_maneuver_marker_screen_space(Spacecraft* craft, Maneuver* maneuver, RenderState* render_state);
void render_orbit(Vec3 position, Vec3 velocity, Vec3 parent_position, double parent_mass, Color orbit_color, RenderState* render_state);
Color get_body_orbit_color(CelestialBody* body);

Loading…
Cancel
Save